Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom /etc/os-release #409

Open
bcressey opened this issue Nov 15, 2024 · 0 comments
Open

custom /etc/os-release #409

bcressey opened this issue Nov 15, 2024 · 0 comments

Comments

@bcressey
Copy link
Contributor

Currently we hardcode the contents of /etc/os-release based on build-related variables.

That locks downstream builds into specific outputs that they may not want; for example, PRETTY_NAME will always be something like "Bottlerocket x.y.z" even if the version isn't meaningful.

What I'd suggest instead is that:

  1. if no /etc/os-release exists in the sys-root, we write the existing os-release as a file with unexpanded variables
  2. then we apply envsubst to /etc/os-release in a second pass to fill in variables we want to replace

The URL fields should also be parameterized so that variable substitution works there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant