Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad file extensions in cluster.py's --center-features don't error #178

Open
justinrporter opened this issue Sep 17, 2019 · 2 comments
Open
Labels
bug good-first-issue this issue would be a good first commit

Comments

@justinrporter
Copy link
Collaborator

cluster.py, if you pass a path with a weird file extension for --center-features, doesn't warn you. For example, if you're doing rmsd clustering, and you give xxx.npy, it will save that, even if it's a pickle.

@justinrporter justinrporter added bug good-first-issue this issue would be a good first commit labels Sep 17, 2019
@arudzinska
Copy link

Hi, is this issue still up? I understand the problem is in this file. I see some warnings related to file extensions already there though.

@justinrporter
Copy link
Collaborator Author

Yes, I think so. There are two related things going on here:

  1. If you use --trajectories instead of --features (they are mutually exclusive), there are two types of files you can get for the output of --center-features. One is an h5, and this is if you pass --topology and --trajectories only once and the other is a pickle, and that's if you pass them more than once.
  2. I think there might actually be some sort of bug where the warning is triggered incorrectly. I'll have to poke around on this a bit more, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good-first-issue this issue would be a good first commit
Projects
None yet
Development

No branches or pull requests

2 participants