Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.80.0 #304

Closed
devhell opened this issue Aug 7, 2024 · 4 comments
Closed

Rust 1.80.0 #304

devhell opened this issue Aug 7, 2024 · 4 comments

Comments

@devhell
Copy link
Contributor

devhell commented Aug 7, 2024

I'm guessing you're already looking into it, so I'll leave this here, just in case: NixOS/nixpkgs#332957

Thank you very much in advance 🍻

@boxdot
Copy link
Owner

boxdot commented Aug 12, 2024

Thank you for reporting. I can't reproduce the compilation issue with rustc 1.80 for the main branch and for the v0.5. v0.4.3 indeed fails to compile.

@devhell Do you want me to backport the fix to v0.4?

@devhell
Copy link
Contributor Author

devhell commented Aug 12, 2024

Thank you for checking, @boxdot. Thank you, as well, for offering to backport to v0.4, but considering #303 is an issue in v0.4 and v0.5 (I've been getting that issue now too), I don't think it makes sense to put in the effort to backport. I believe it would make more sense to wait until you've released an update that includes the fix for #303. Once you have, I'll immediately upgrade gurk-rs in nixpkgs.

@boxdot
Copy link
Owner

boxdot commented Sep 2, 2024

Version 0.5 containing the fix is released

@boxdot boxdot closed this as completed Sep 2, 2024
@devhell
Copy link
Contributor Author

devhell commented Sep 5, 2024

Thank you, @boxdot! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants