Fixed block logging bugs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify build.gradle and change nukkit maven repo
block lookup work for the most part now. Known bugs: - liquids placed on any block other than the z block aren't logged - Filling a bucket with liquid hides liquid place logs (shift clicking shows Air -> Air - something might be messed up with getting time from the database (might be fixed) - Rollback functionality is completely non-existant
All block edits should now logged correctly. Known Bugs: - Issue with purging old records from the database: https://hastebin.com/nucuxovahu.pl - Rollbacks still don't work, fawe says the job has been completed but no blocks change and when the rollback queue is flushed it throws this error: https://hastebin.com/lexebayaju.pl
I believe all block logging is working correctly. Rollbacks still don't work correctly
Support for NukkitX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I have fixed all block logging related errors/bugs. Actual rollbacks however are still not functional but throw no errors.