Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the bases from construct_smooth_data #2

Closed
boyiguo1 opened this issue May 11, 2021 · 1 comment
Closed

Rename the bases from construct_smooth_data #2

boyiguo1 opened this issue May 11, 2021 · 1 comment
Labels
Development Forthcoming Enhancement To be improved for existing functions

Comments

@boyiguo1
Copy link
Owner

Currently, the "design matrix" returned from contruct_smooth_data are named in the pattern var_name.baseX. However, such a naming convention doesn't help to distinguish the null space from the penalized space, which creates more problems during variable/function selection.

The naming convention should be a combination of var_name.nullX and var_name.penX. It also helps with creating groups.

@boyiguo1 boyiguo1 added the Enhancement To be improved for existing functions label May 11, 2021
@boyiguo1
Copy link
Owner Author

boyiguo1 commented May 19, 2021

Fixed as suggested. See commit 900b4d1

@boyiguo1 boyiguo1 added the Development Forthcoming label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development Forthcoming Enhancement To be improved for existing functions
Projects
None yet
Development

No branches or pull requests

1 participant