Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Comments #1

Open
bucko13 opened this issue Jan 4, 2019 · 0 comments
Open

UX Comments #1

bucko13 opened this issue Jan 4, 2019 · 0 comments

Comments

@bucko13
Copy link
Contributor

bucko13 commented Jan 4, 2019

Just some comments based on playing with the widget a bit.

  • I think it would probably be good to clear the price immediately when an exchange market is changed. It's a little jarring as a user when you switch but the price stays the same for a half second and then changes. I would expect it to change immediately to something like ... and then update once the value is received
  • Same point above for changing the fiat. It feels weird that the symbol changes then the amount updates.
  • I was noticing that when I had @bpanel/bpanel-footer and @bpanel/footer-address, at some screen widths the exchange selector would flicker out. I think this is because of the col width. It might help to specify a width. col-4 seemed to ensure it displayed for me, but it also squeezes the others, so it's not a big deal either way.

That's about it! I love being able to see the price in my footer. Great job 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bucko13