Collapsed Event Sub-Processes do not show the type

[rajgoel]

Describe the Bug

According to Table 12.16, p. 388 of the spec, collapsed event-subprocesses having a unique start event with event definition should be depicted with an icon representing the start event type. This is not shown in the modeler.

Steps to Reproduce

Load a model with a collapsed submodule or collapse an event subprocess using the module https://github.com/bpmn-os/bpmn-js-collapse-event-subprocess.

Expected Behavior

If a unique start event is provided, the collapsed event subprocess should be decorated with an icon representing the start event type.

Environment

• Library version: 16.3.2

---

Related to #690

[nikku]

Thanks for opening this issue.

Consider a contribution if you want to move this topic forward.

[rajgoel]

@nikku I just found a working solution and add it to https://github.com/bpmn-os/bpmn-js-collapse-event-subprocess/.

The only small problem is that a little bit of padding would be nice

https://github.com/bpmn-os/bpmn-js-collapse-event-subprocess/blob/2bb965d4b3bb77778938bdd0475a4a2920d3d59c/CollapsedEventSubProcessDecorator.js#L55-L61

Maybe you have an idea how to move the decorator a bit away from the boundary.

[nikku]

I'd ask you to file a feature request in the linked repository (which is outside of our sphere).

Never mind my previous comment. I've seen you're the owner.

[rajgoel]

Hi, the linked repository is mine where I have all my BPMN related projects. It would be great to transfer this to bpmn-js.

[nikku]

You can wrap whatever is rendered into a SVG group with a transform (x, y) to pad it.

[rajgoel]

Thanks a lot for the hint, helped me figure out to do this. Looks much better now.

I think this could be a useful addition to bpmn-js as it affects implementation of the standard. Do you want to take over ownership of this module, or what is your policy concerning user provided modules?

[NPDeehan]

Just wanted to drop a comment to say that this has been recently requested by some community folk. Great to see your work on this @rajgoel thanks!
https://forum.camunda.io/t/collapsed-event-sub-process-clarification/49904

[philippfromme]

@rajgoel Would you be open to create a PR that adds this feature to bpmn-js? We can still decide to disable it by default.

[bpmn-os]

@philippfromme How would this PR have to look like? Currently my solution is a module that you load separately. Sorry, if this is a stupid question, but I currently have no idea how and where the code would need be integrated into bpmn-js. If you can give me a hint, I will give it a try.

[rajgoel]

@philippfromme Sorry for the confusion with my reply using another user name. I use bpmn-os for all my bpmn related stuff.