Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Links in New Tab by Default #116

Closed
philippfromme opened this issue Jun 28, 2021 · 11 comments · Fixed by #613
Closed

Open Links in New Tab by Default #116

philippfromme opened this issue Jun 28, 2021 · 11 comments · Fixed by #613
Assignees
Labels
enhancement New feature or request needs discussion Needs further discussion

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Jun 28, 2021

Is your feature request related to a problem? Please describe

When using links in the markdown/HTML form field the linked documents open inside the same tab unless target="_blank" is added manually.

aQD4CrOEby

This behavior might be unexpected from the user's point of view.

Describe the solution you'd like

A potential fix would be to add target="_blank" by default.

Describe alternatives you've considered

Doing nothing and leaving the decision to the developer integrating the library. (cf. https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload)

Additional context

Follow-up to #101

@philippfromme philippfromme added enhancement New feature or request needs discussion Needs further discussion labels Jun 28, 2021
@philippfromme philippfromme added the backlog Queued in backlog label Jun 28, 2021
@nikku
Copy link
Member

nikku commented Jun 28, 2021

Can we make this a proper enhancement request?

I'd love to add alternative behavior I'd consider. Given that integrators can already intercept page navigation (and cancel it, cf. screen cast) doing nothing at all is a fine solution, too. Especially because it is good practice to not forcefully open links externally, too.

@nikku nikku added help wanted Extra attention is needed and removed backlog Queued in backlog labels Jun 28, 2021
@philippfromme
Copy link
Contributor Author

Okay, will add the alternative. I had already added the needs discussion label to indicate that this needs further discussion.

@philippfromme
Copy link
Contributor Author

@nikku I've updated the isse.

@andreasgeier
Copy link
Contributor

I'm in favor of a new tab as I already mentioned in this issue. Staying on the page is possibly destructive. Also, the use cases I can imagine (open docs, check other systems, additional information, etc.) are speaking for a new tab solution.

@nikku
Copy link
Member

nikku commented Jun 29, 2021

It is trivial for library integrators to hook into the navigation and prevent it. In fact that is what we already do on our demo as well as in the Camunda Modeler.

Building a library we must assume that integrators know what they are doing (to some extend). Maybe we can make the behavior configurable one day, however let us not force this behavior upon our users.

@nikku
Copy link
Member

nikku commented Jun 29, 2021

On a related note it should be possible to manually add your own <a target="_blank"> links into the template if you wish to. That is not the case, as we're running into an upstream bug. If we had it, people could always add <a target="_blank"> links to overrule good web practices.

@nikku
Copy link
Member

nikku commented Jun 30, 2021

Users will be able to assert full control over their link open behavior once #121 is merged.

@nikku
Copy link
Member

nikku commented Jul 5, 2021

Given the mixed opinions on this one and existing workarounds in place, let's close this one and await further feedback.

@nikku nikku closed this as completed Jul 5, 2021
@korthout
Copy link

I've encountered a need for this as well.

We use Tasklist in the release process of Zeebe with extensive Forms usage. Many of the forms use Markdown formatted text often with links. As far as I've seen, these links won't ever refer to Tasklist, they are always external. Leaving Tasklist when clicking these links is kinda annoying, because you click the link to learn more about how to complete this task. Then once you know, you generally want to return to Tasklist to complete the task. Which means finding it in your browser history.

I understand I focus here on Tasklist, and I don't know the full extent of other use cases for the forms, but in my opinion it makes a lot of sense to open the rendered markdown links in a new tab. Or make this configurable, so a tool like Tasklist can enable it.

@nikku nikku reopened this Dec 28, 2021
@nikku nikku added the backlog Queued in backlog label Jan 11, 2022
@pinussilvestrus pinussilvestrus removed the help wanted Extra attention is needed label Feb 20, 2023
@christian-konrad
Copy link
Contributor

Let's fix this now, it is pending for a while and quite a problem. @marcosgvieira

@Skaiir Skaiir self-assigned this Apr 19, 2023
@Skaiir
Copy link
Contributor

Skaiir commented Apr 19, 2023

We want this definitely, but we don't want to modify existing behavior, so I'm implementing a new flag for library consumers.

Skaiir added a commit that referenced this issue Apr 19, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Apr 19, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 19, 2023
Skaiir added a commit that referenced this issue Apr 20, 2023
Skaiir added a commit that referenced this issue Apr 20, 2023
Skaiir added a commit that referenced this issue Apr 20, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion Needs further discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants