-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Links in New Tab by Default #116
Comments
Can we make this a proper enhancement request? I'd love to add alternative behavior I'd consider. Given that integrators can already intercept page navigation (and cancel it, cf. screen cast) doing nothing at all is a fine solution, too. Especially because it is good practice to not forcefully open links externally, too. |
Okay, will add the alternative. I had already added the needs discussion label to indicate that this needs further discussion. |
@nikku I've updated the isse. |
I'm in favor of a new tab as I already mentioned in this issue. Staying on the page is possibly destructive. Also, the use cases I can imagine (open docs, check other systems, additional information, etc.) are speaking for a new tab solution. |
It is trivial for library integrators to hook into the navigation and prevent it. In fact that is what we already do on our demo as well as in the Camunda Modeler. Building a library we must assume that integrators know what they are doing (to some extend). Maybe we can make the behavior configurable one day, however let us not force this behavior upon our users. |
On a related note it should be possible to manually add your own |
Users will be able to assert full control over their link open behavior once #121 is merged. |
Given the mixed opinions on this one and existing workarounds in place, let's close this one and await further feedback. |
I've encountered a need for this as well. We use Tasklist in the release process of Zeebe with extensive Forms usage. Many of the forms use Markdown formatted text often with links. As far as I've seen, these links won't ever refer to Tasklist, they are always external. Leaving Tasklist when clicking these links is kinda annoying, because you click the link to learn more about how to complete this task. Then once you know, you generally want to return to Tasklist to complete the task. Which means finding it in your browser history. I understand I focus here on Tasklist, and I don't know the full extent of other use cases for the forms, but in my opinion it makes a lot of sense to open the rendered markdown links in a new tab. Or make this configurable, so a tool like Tasklist can enable it. |
Let's fix this now, it is pending for a while and quite a problem. @marcosgvieira |
We want this definitely, but we don't want to modify existing behavior, so I'm implementing a new flag for library consumers. |
Is your feature request related to a problem? Please describe
When using links in the markdown/HTML form field the linked documents open inside the same tab unless
target="_blank"
is added manually.This behavior might be unexpected from the user's point of view.
Describe the solution you'd like
A potential fix would be to add
target="_blank"
by default.Describe alternatives you've considered
Doing nothing and leaving the decision to the developer integrating the library. (cf. https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload)
Additional context
Follow-up to #101
The text was updated successfully, but these errors were encountered: