Skip to content

Commit

Permalink
Don't typeAhead erroneous parsing trees related to export statements
Browse files Browse the repository at this point in the history
  • Loading branch information
KacperFKorban committed Nov 6, 2024
1 parent ec5cbcc commit 74920d3
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 2 deletions.
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Namer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ class Namer { typer: Typer =>
private def exportForwarders(exp: Export, pathMethod: Symbol)(using Context): List[tpd.MemberDef] =
val buf = new mutable.ListBuffer[tpd.MemberDef]
val Export(expr, selectors) = exp
if expr.isEmpty then
if expr.isEmpty || selectors.exists(_.imported.name == nme.ERROR) then
report.error(em"Export selector must have prefix and `.`", exp.srcPos)
return Nil

Expand Down
32 changes: 32 additions & 0 deletions tests/neg/i20511-1.check
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
-- [E083] Type Error: tests/neg/i20511-1.scala:7:7 ---------------------------------------------------------------------
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error
| ^^^^^^^^^^^^
| Int => Double is not a valid export prefix, since it is not an immutable path
|
| longer explanation available when compiling with `-explain`
-- [E083] Type Error: tests/neg/i20511-1.scala:7:27 --------------------------------------------------------------------
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error
| ^^^^^^^^^^
| Any is not a valid export prefix, since it is not an immutable path
|
| longer explanation available when compiling with `-explain`
-- Error: tests/neg/i20511-1.scala:7:38 --------------------------------------------------------------------------------
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error
| ^^^^^
| no eligible member apply at {
| def $anonfun(crustType: Double): Double = pakiet.crustPrice(crustType)
| closure(pakiet.$anonfun:Any)
| }
-- [E083] Type Error: tests/neg/i20511-1.scala:7:45 --------------------------------------------------------------------
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error
| ^^^^^^^^^^
| Any is not a valid export prefix, since it is not an immutable path
|
| longer explanation available when compiling with `-explain`
-- Error: tests/neg/i20511-1.scala:7:56 --------------------------------------------------------------------------------
7 |export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error
| ^^^^^^
| no eligible member unlift at {
| def $anonfun(crustType: Double): Double = pakiet.crustPrice(crustType)
| closure(pakiet.$anonfun:Any)
| }
2 changes: 1 addition & 1 deletion tests/neg/i20511-1.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ def toppingPrice(size: Int): Double = ???

def crustPrice(crustType: Double): Double = ???

export toppingPrice.apply, crustPrice.unlift // error // error // error
export toppingPrice.apply, crustPrice.apply, crustPrice.unlift // error // error // error // error // error
12 changes: 12 additions & 0 deletions tests/neg/i20511.check
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
-- [E040] Syntax Error: tests/neg/i20511.scala:7:19 --------------------------------------------------------------------
7 |export toppingPrice, crustPrice // error // error
| ^
| '.' expected, but ',' found
-- [E040] Syntax Error: tests/neg/i20511.scala:8:0 ---------------------------------------------------------------------
8 |val i = 1 // error
|^^^
|'.' expected, but 'end of statement' found
-- Error: tests/neg/i20511.scala:7:21 ----------------------------------------------------------------------------------
7 |export toppingPrice, crustPrice // error // error
| ^^^^^^^^^^
| Export selector must have prefix and `.`

0 comments on commit 74920d3

Please sign in to comment.