Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopping-list project - checkIfItemExists - edit mode #11

Open
dmb225 opened this issue Sep 25, 2024 · 0 comments
Open

shopping-list project - checkIfItemExists - edit mode #11

dmb225 opened this issue Sep 25, 2024 · 0 comments

Comments

@dmb225
Copy link

dmb225 commented Sep 25, 2024

Hello.

Thank you for this project.
Why don't you check the existence of the object even in edit mode?
It's possible that the updated item already exists, isn't it?

  if (isEditMode) {
    const itemToEdit = itemList.querySelector('.edit-mode');

    removeItemFromStorage(itemToEdit.textContent);
    itemToEdit.classList.remove('edit-mode');
    itemToEdit.remove();
    isEditMode = false;
  } else {
    if (checkIfItemExists(newItem)) {
      alert('That item already exists!');
      return;
    }
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant