Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-BrainGlobe-specific Qt elements to a separate NIU repository #107

Open
niksirbi opened this issue Nov 21, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@niksirbi
Copy link
Member

Is your feature request related to a problem? Please describe.
This issue is following up on a discussion we started on zulip.

The gist of the problem is that brainglobe-utils currently hosts some Qt elements, like CollapsibleWidgetContainer that are (or can be) useful for projects beyond BrainGlobe. The first example of that is the movement napari plugin, which depends on the aforementioned element. Depending on brainglobe-utils means also getting other stuff that movement and similar projects won't need - e.g. some BrainGlobe-specific dependencies, and the brainmapper widget.

While this is not critical yet, it may soon reach a breaking point, especially if more repos (NIU or otherwise) start re-using those Qt elements for their own sake.

Describe the solution you'd like

  • Identify all non-brainglobe-specific Qt elements
  • Move those to a new neuroinformatics-unit/qt-widgets repository (name subject-to-change)
  • Make brainglobe-utils and movement depend on that new repository.

Describe alternatives you've considered
Leave things as they are, as nothing is broken, yet.

Additional context
This was recently re-brought to my attention thanks to @lochhh noticing that brainmapper appeared among available napari plugins when using movement.

@niksirbi niksirbi added the enhancement New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant