add to viewer button > double-click

[alessandrofelder]

Description

What is this PR

• Bug fix
• Addition of a new feature
• Other

Why is this PR needed?
Our widgets are multiplying and there's no space for them any more

What does this PR do?

• moves the atlas info to be a tooltip on the atlas table view
• removes the download and add to viewer button, which are replaced by double-clicking rows
• to guard users from a too rash download, a confirmation dialog is displayed

To account for this, the atlas widget tests were refactored heavily. This refactor includes the adding of a new fixture in conftest.py to simplify emulating a user doubleclicking on a view.

References

Closes #45

How has this PR been tested?

Existing tests were refactored and some new ones added. Automated tests pass, and I've tested manually too.

Is this a breaking change?

yes, the UI changes completely (but no underlying fu

Does this PR require an update to the documentation?

Nope

Checklist:

• The code has been tested locally
• Tests have been added to cover all new functionality (unit & integration)
• [n/a] The documentation has been updated to reflect any changes
• The code has been formatted with pre-commit

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.59 🎉

Comparison is base (78bf071) 93.10% compared to head (1ee198c) 94.69%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   93.10%   94.69%   +1.59%     
==========================================
  Files           9       11       +2     
  Lines         377      415      +38     
==========================================
+ Hits          351      393      +42     
+ Misses         26       22       -4     

Impacted Files	Coverage Δ
src/brainglobe_napari/atlas_download_dialog.py	100.00% <100.00%> (ø)
src/brainglobe_napari/atlas_viewer_widget.py	98.16% <100.00%> (+2.19%)	⬆️
src/brainglobe_napari/tests/conftest.py	55.55% <100.00%> (+18.71%)	⬆️
...rainglobe_napari/tests/test_atlas_viewer_widget.py	100.00% <100.00%> (+1.47%)	⬆️
...rc/brainglobe_napari/tests/test_download_dialog.py	100.00% <100.00%> (ø)
...e_napari/tests/test_napari_atlas_representation.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adamltyson]

LGTM. I added a small comment about the dialogue.

Happy to merge, but I think the UI needs to be made more intuitive (not sure how) or add some instructions to the user within the UI.

[alessandrofelder]

... I think the UI needs to be made more intuitive (not sure how) or add some instructions to the user within the UI.

I agree. For now, there are instructions for the table to double-click a row in its tooltip. I would suggest this be complement with an info logo that you can hover over somewhere?

[Edit: moving this discussion to #52]