capture the custom_locale from the API and use it when downloading translations #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frett
force-pushed
the
patch/customLocaleSupport
branch
from
e405ec9
to
93e1195
Compare
frett
commented
Apr 3, 2024
| Language("en-US", null, "English (United States)", false, "0.0%"), | ||
| Language("pa-IN", null, "Punjabi (India)", false, "93.8%"), | ||
| Language("es-ES", null, "Spanish (Spain)", false, "100.0%"), | ||
| Language("hi", "Hinglish LAT-IN", "Hindi", false, "98.1%"), |
There was a problem hiding this comment.
this language has "custom_locale": "Hinglish LAT-IN" in project_languages_response.json.
This is not actually a valid language tag, and already produces invalid results when downloading from the OneSky UI.
|
bumping this to see if there is interest before I spend the effort to publish an internal fork for usage in our projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13