Datashare add schema tables #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functionality is available from AWS console.
…functionality is available from AWS console.
…functionality is available from AWS console.
Datashare add schema tables
winglot
reviewed
Apr 21, 2022
| } | ||
|
|
||
| func resourceRedshiftDatashareRemoveTablesInSchema(tx *sql.Tx, shareName string, tables string) error { | ||
| query := fmt.Sprintf("ALTER DATASHARE %s REMOVE TABLE %s", pq.QuoteIdentifier(shareName), pq.QuoteIdentifier(tables)) |
There was a problem hiding this comment.
Have you tested that it will actually work for more than one table in the list? To my knowledge, this will produce an SQL like ALTER DATASHARE "xyz" REMOVE TABLE "schema.table1,schema.table2" which will try to remove the table named "schema.table1,schema.table2" as one name rather than 2 separate tables (due to double quotes). The same would apply to ADD TABLE query.
I'm asking, because I've faced a similar issue with removing users from groups and had to quote each name individually before joining. See https://github.com/brainly/terraform-provider-redshift/blob/master/redshift/resource_redshift_group.go#L228-L232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a schema is added to datashare, all its tables are automatically added.
In this PR we have introduced a new parameter schema_tables to specify schema tables to be added to datashare