Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash Repo not really supported #3

Open
davedash opened this issue Feb 9, 2015 · 4 comments
Open

Logstash Repo not really supported #3

davedash opened this issue Feb 9, 2015 · 4 comments

Comments

@davedash
Copy link

davedash commented Feb 9, 2015

This repo:

https://github.com/brandentimm/logstash_forwarder-formula/blob/master/logstash_forwarder/repo.sls#L10

Is not supported, as noted by: elastic/logstash-forwarder#184 (comment)

There should be a more recommended way of obtaining this package.

@brandentimm
Copy link
Owner

Thanks for the report, I hadn't noticed it. I'll look into building from github's master for the project when I have time, otherwise pull requests are welcome as always!

@brandentimm
Copy link
Owner

Well, from looking at their build instructions, this will be annoying.

Building the software requires golang, which I'm not opposed to, but since so many people have carefully managed Go installations, I'm loathe to install it just to build the software and possibly add a conflicting Go runtime to somebody's system.

It's even worse if we wanted to package it on-system, as in addition to golang we'd need ruby, gem, and a specific gem 'fpm'. Again, many people have carefully managed ruby/gem setups, that I would be loathe to trample

This formula may just need to sit idle until the logstash-forwarder folks figure out a reasonable packaging strategy.

@davedash
Copy link
Author

davedash commented Feb 9, 2015

Yeah - or let people supply their own repo that has the package as a pillar?

I'm signing up for packagelcoud.io just so I can build this package locally
and publish it there - kind of involved for just one package, so it might
take me a while, if I have something decent I can submit a PR.

On Mon Feb 09 2015 at 1:06:22 PM Branden Timm [email protected]
wrote:

Well, from looking at their build instructions, this will be annoying.

Building the software requires golang, which I'm not opposed to, but since
so many people have carefully managed Go installations, I'm loathe to
install it just to build the software and possibly add a conflicting Go
runtime to somebody's system.

It's even worse if we wanted to package it on-system, as in addition to
golang we'd need ruby, gem, and a specific gem 'fpm'. Again, many people
have carefully managed ruby/gem setups, that I would be loathe to trample

This formula may just need to sit idle until the logstash-forwarder folks
figure out a reasonable packaging strategy.


Reply to this email directly or view it on GitHub
#3 (comment)
.

@brandentimm
Copy link
Owner

I like your idea of leaving the package repository url as a bit of pillar info. We'd have to remove the GPG key step too, and update the README, but those are pretty trivial changes.

I'll see what I can work up this evening. Thanks for the second set of eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants