Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

replace deprecated request library #58

Open
diracdeltas opened this issue May 25, 2023 · 2 comments
Open

replace deprecated request library #58

diracdeltas opened this issue May 25, 2023 · 2 comments
Assignees
Labels

Comments

@diracdeltas
Copy link

request is no longer maintained, so the only way to resolve https://github.com/brave-intl/currency/security/dependabot/28 is to replace it.

@nvonpentz
Copy link
Contributor

nvonpentz commented May 30, 2023

This codebase does not use the request package directly, however two of it's dependencies do use it:

  • node-binance-api - as far as I can tell, this is unused and can be removed
  • oxr - a npm package to interface with the open exchange rates API. I think there's a good chance all code related to this can be removed, since (I believe) we should be getting exchange rate data from coingecko. I don't know for sure yet which bat-ratios endpoints use the OXR code, how many active users of those endpoints there are, and whether it's feasible to cleanly remove the OXR code and still have everything "work"

@nvonpentz
Copy link
Contributor

I'm also looking into deprecating this service as a way to solve this problem

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants