Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift #17856 and #18141 fixes to our HTTPS Upgrades feature in 1.51.x #29914

Closed
arthuredelstein opened this issue Apr 21, 2023 · 1 comment
Closed

Uplift #17856 and #18141 fixes to our HTTPS Upgrades feature in 1.51.x #29914

arthuredelstein opened this issue Apr 21, 2023 · 1 comment
Assignees
@arthuredelstein
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
1.51.x - Release

Comments

@arthuredelstein
Copy link

arthuredelstein commented Apr 21, 2023 •
edited
Loading

There are two recent PRs merged into master (1.52.x) that we would like to uplift into 1.51.x:

In brave/brave-core#17856, we migrated our fixes to Chrome's HTTPS First Mode v2. Using v2 also incidentally fixes the referrer problem reported in #28809.

In brave/brave-core#18141, we enhanced our HTTPS Upgrades feature to fall back when an HTTP response returns an HTTPS error code (>= 400).

(QA testing plans are described in #28935 and #28013)
@arthuredelstein arthuredelstein added OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 21, 2023
@arthuredelstein arthuredelstein self-assigned this Apr 21, 2023
@arthuredelstein arthuredelstein added this to the 1.51.x - Beta milestone Apr 21, 2023
@arthuredelstein arthuredelstein mentioned this issue Apr 21, 2023
Merged
25 tasks
@arthuredelstein arthuredelstein added QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Apr 21, 2023
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2023

Closing and labelling as QA/No & release-notes/exclude as #28935, #28013 & #28809 will be used for verifications by QA. The mentioned issues will also be used for notes rather than the above.

@kjozwiak kjozwiak closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthuredelstein arthuredelstein

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
1.51.x - Release
Development

No branches or pull requests
2 participants
@arthuredelstein @kjozwiak