Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator is not clearly shown for adjacent inactive tabs in split view #42304

Open
2 of 6 tasks
MadhaviSeelam opened this issue Nov 14, 2024 · 7 comments · May be fixed by brave/brave-core#27008
Open
2 of 6 tasks

Separator is not clearly shown for adjacent inactive tabs in split view #42304

MadhaviSeelam opened this issue Nov 14, 2024 · 7 comments · May be fixed by brave/brave-core#27008
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes split view

Comments

@MadhaviSeelam
Copy link

Description

Found while testing #39486. If Split view is enabled via brave://flags/#brave-split-view and go to split screen view, some of the adjacent inactive tabs do not show separator. This happens both in light and dark theme.

Steps to reproduce

  1. Install 1.74.4
  2. launch Brave
  3. enable split view via brave://flags/#brave-split-view
  4. select split view via context menu of a tab
  5. notice inactive adjacent tabs do not show separator

Actual result

light dark
Image Image

Expected result

Separator should show

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.74.4 Chromium: 131.0.6778.39 (Official Build) beta (64-bit)
-- | --
Revision | 15328654b03f358466ab746b5d12a68e7fdb5017
OS | Windows 11 Version 23H2 (Build 22631.4460)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@rebron @aguscruiz @simonhong
cc: @brave/qa-team

@MadhaviSeelam MadhaviSeelam changed the title Separator is not clearly shown for adjacent inactive tabs Separator is not clearly shown for adjacent inactive tabs in split view Nov 14, 2024
@aguscruiz
Copy link

Updated design here:
https://www.figma.com/design/Dt0iJdVaaAj7DikWLO1P7I/Split-view-%2F-Sidebar-browsing?node-id=2469-11836&t=bZFVWJMSvlzoefYl-1

Image

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Nov 20, 2024
@rebron rebron moved this to On Deck in Front End Nov 20, 2024
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 26, 2024
@simonhong simonhong moved this from On Deck to In progress in Front End Dec 12, 2024
@simonhong
Copy link
Member

Working on this.

@simonhong
Copy link
Member

@aguscruiz In the figma, DesktopBrowser/TabBar/Split View - Divider token is used but I couldn't find it from generated file nala_color_id.h like below.
Do we need to bump nala to use it?

Image

@aguscruiz
Copy link

@simonhong maybe! I guess Nala is a bit more behind than what I thought.

@aguscruiz
Copy link

Let me know if you'd prefer for me to give you the primitive values instead to unblock you. I have them too

@simonhong
Copy link
Member

Let me know if you'd prefer for me to give you the primitive values instead to unblock you. I have them too

Code is ready but it seems it's resolved when brave/brave-core#26995 is merged?

@aguscruiz
Copy link

Probably yes! Let's see.

simonhong added a commit to brave/brave-core that referenced this issue Dec 13, 2024
fix brave/brave-browser#42304

Also applied latest split view tab's background color.
@simonhong simonhong linked a pull request Dec 13, 2024 that will close this issue
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Dec 14, 2024
fix brave/brave-browser#42304

Also applied latest split view tab's background color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes split view
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants