Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two ZCash accounts get created on buy screen #42788

Closed
2 of 6 tasks
Douglashdaniel opened this issue Dec 10, 2024 · 2 comments · Fixed by brave/brave-core#26954
Closed
2 of 6 tasks

Two ZCash accounts get created on buy screen #42788

Douglashdaniel opened this issue Dec 10, 2024 · 2 comments · Fixed by brave/brave-core#26954
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.74.x - Release

Comments

@Douglashdaniel
Copy link

Description

When you are prompt to create a ZCash account on the new Buy screen. There are some instances where 2 accounts get created.

Steps to reproduce

  1. Create a brand new wallet and navigate to the Buy screen
  2. Select ZCash as the asset to buy, when prompt to create an account click Cancel
  3. Re-select ZCash as the asset to buy, when prompt to create an account click Create
  4. You will now have 2 ZCash accounts.

Actual result

see brave/brave-core#26850 (comment)

Expected result

Should only create 1 account.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.44 Chromium: 131.0.6778.85 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@Douglashdaniel Douglashdaniel added bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/exclude labels Dec 10, 2024
@Douglashdaniel Douglashdaniel self-assigned this Dec 10, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Dec 10, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Dec 10, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Dec 10, 2024
@srirambv srirambv mentioned this issue Dec 11, 2024
Closed
6 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Dec 12, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 12, 2024
@kjozwiak kjozwiak mentioned this issue Dec 16, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.74.29 or higher for 1.74.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.74.31 Chromium: 132.0.6834.46 (Official Build) beta (64-bit)
Revision fbd8f1448360d52b035f31483af235134e7adfcc
OS Windows 11 Version 23H2 (Build 22631.4460)
42788.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.74.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Prevent Double Account Creation on Buy Screen brave/brave-core
4 participants
@kjozwiak @srirambv @Douglashdaniel @brave-builds