From 25c6501c67699d7f57607a22ddaf949e4efd7ad1 Mon Sep 17 00:00:00 2001 From: Brandon Date: Wed, 11 Dec 2024 18:59:54 -0500 Subject: [PATCH] Address feedback --- ui/webui/resources/sources.gni | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/ui/webui/resources/sources.gni b/ui/webui/resources/sources.gni index c1fab100145d..df17f0e996d2 100644 --- a/ui/webui/resources/sources.gni +++ b/ui/webui/resources/sources.gni @@ -8,27 +8,21 @@ brave_resources_extra_grdps_path = "$root_gen_dir/brave/ui/webui/resources" -brave_resources_extra_grdps = [] +brave_resources_extra_grdps = [ + "$brave_resources_extra_grdps_path/brave_static_resources.grdp", + "$root_gen_dir/brave/web-ui-leo/leo.grdp", +] -brave_resources_extra_grdps_deps = [] +brave_resources_extra_grdps_deps = [ "//brave/ui/webui/resources:grdp" ] -# ios does not need any static resources -if (is_ios) { - brave_resources_extra_grdps += [ - "$brave_resources_extra_grdps_path/brave_static_resources.grdp", - "$root_gen_dir/brave/web-ui-leo/leo.grdp", - ] -} else { +# ios does not need font or icon resources +if (!is_ios) { brave_resources_extra_grdps += [ "$brave_resources_extra_grdps_path/brave_fonts_resources.grdp", - "$brave_resources_extra_grdps_path/brave_static_resources.grdp", "$brave_resources_extra_grdps_path/brave_icons_resources.grdp", - "$root_gen_dir/brave/web-ui-leo/leo.grdp", ] } -brave_resources_extra_grdps_deps += [ "//brave/ui/webui/resources:grdp" ] - # At the moment, all non-static resources are only required for polymer WebUI. # This could change and, when it does, the `include_polymer` conditional can be removed # here and the one in //brave/ui/webui/resources/BUILD.gn be relied on to only add