Removes the "Account name" input field.

brave · Dec 10, 2024 · 9e189ec · 9e189ec
1 parent e19a528
commit 9e189ec
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 21 deletions.
diff --git a/app/brave_settings_strings.grdp b/app/brave_settings_strings.grdp
@@ -71,12 +71,6 @@
   <message name="IDS_SETTINGS_BRAVE_ACCOUNT_EMAIL_INPUT_ERROR_MESSAGE" translateable="false" desc="Error message for when the user tries to use a @bravealias.com email address when creating their Brave Account">
     You can't use @bravealias.com addresses for creating Brave accounts. Please try again with a different domain.
   </message>
-  <message name="IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_LABEL" translateable="false" desc="Label for the 'Account name' input field">
-    Account name
-  </message>
-  <message name="IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_PLACEHOLDER" translateable="false" desc="Placeholder for the 'Account name' input field">
-    Enter a name for your account
-  </message>
   <message name="IDS_SETTINGS_BRAVE_ACCOUNT_CREATE_PASSWORD_INPUT_LABEL" translateable="false" desc="Label for the 'Create a password' input field">
     Create a password
   </message>

diff --git a/browser/resources/settings/getting_started_page/brave_account_create_dialog.html.ts b/browser/resources/settings/getting_started_page/brave_account_create_dialog.html.ts
@@ -32,10 +32,6 @@ export function getHtml(this: SettingsBraveAccountCreateDialogElement) {
             <div>$i18n{braveAccountEmailInputErrorMessage}</div>
           </div>
         </leo-input>
-        <leo-input placeholder="$i18n{braveAccountAccountNameInputPlaceholder}"
-                   @input=${this.onAccountNameInput}>
-          <div class="label">$i18n{braveAccountAccountNameInputLabel}</div>
-        </leo-input>
         <leo-input placeholder="$i18n{braveAccountPasswordInputPlaceholder}"
                    showErrors
                    type="password"
@@ -85,7 +81,6 @@ export function getHtml(this: SettingsBraveAccountCreateDialogElement) {
       <div slot="buttons">
         <leo-button ?isDisabled=${!this.isEmailValid
                                || this.isEmailValid && this.isEmailBraveAlias
-                               || !this.isAccountNameValid
                                || this.passwordStrength !== 100
                                || this.passwordConfirmation !== this.password
                                || !this.isCheckboxChecked}

diff --git a/browser/resources/settings/getting_started_page/brave_account_create_dialog.ts b/browser/resources/settings/getting_started_page/brave_account_create_dialog.ts
@@ -124,7 +124,6 @@ export class SettingsBraveAccountCreateDialogElement extends CrLitElement {
   static override get properties() {
     return {
       email: { type: String },
-      isAccountNameValid: { type: Boolean },
       isCheckboxChecked: { type: Boolean },
       isEmailBraveAlias: { type: Boolean },
       isEmailValid: { type: Boolean },
@@ -140,10 +139,6 @@ export class SettingsBraveAccountCreateDialogElement extends CrLitElement {
     this.isEmailBraveAlias = this.email.endsWith('@bravealias.com')
   }
 
-  protected onAccountNameInput(detail: { value: string }) {
-    this.isAccountNameValid = detail.value.length !== 0
-  }
-
   protected onPasswordInput(detail: { value: string }) {
     this.password = detail.value
     this.browserProxy.getPasswordStrength(this.password).then(
@@ -176,7 +171,6 @@ export class SettingsBraveAccountCreateDialogElement extends CrLitElement {
     BraveAccountBrowserProxyImpl.getInstance()
   protected email: string = ''
   protected icon: string = 'warning-triangle-filled'
-  protected isAccountNameValid: boolean = false
   protected isCheckboxChecked: boolean = false
   protected isEmailBraveAlias: boolean = false
   protected isEmailValid: boolean = false

diff --git a/browser/ui/webui/settings/brave_settings_localized_strings_provider.cc b/browser/ui/webui/settings/brave_settings_localized_strings_provider.cc
@@ -162,10 +162,6 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source,
        IDS_SETTINGS_BRAVE_ACCOUNT_CREATE_DIALOG_DESCRIPTION},
       {"braveAccountEmailInputErrorMessage",
        IDS_SETTINGS_BRAVE_ACCOUNT_EMAIL_INPUT_ERROR_MESSAGE},
-      {"braveAccountAccountNameInputLabel",
-       IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_LABEL},
-      {"braveAccountAccountNameInputPlaceholder",
-       IDS_SETTINGS_BRAVE_ACCOUNT_ACCOUNT_NAME_INPUT_PLACEHOLDER},
       {"braveAccountCreatePasswordInputLabel",
        IDS_SETTINGS_BRAVE_ACCOUNT_CREATE_PASSWORD_INPUT_LABEL},
       {"braveAccountPasswordStrengthMeterWeak",