Skip to content

Commit

Permalink
Merge pull request #26458 from brave/android_browser_ui_strings_fix
Browse files Browse the repository at this point in the history
[Android] Fix for branding in `browser_ui` component strings
  • Loading branch information
samartnik authored Nov 11, 2024
2 parents ec97acd + 538b167 commit ce42903
Show file tree
Hide file tree
Showing 6 changed files with 2,297 additions and 1 deletion.
5 changes: 4 additions & 1 deletion build/commands/lib/l10nUtil.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ const androidTabUiStringsPath = path.resolve(path.join(srcDir, 'chrome', 'androi
const braveAndroidTabUiStringsPath = path.resolve(path.join(srcDir, 'brave', 'android', 'features', 'tab_ui', 'java', 'strings', 'android_chrome_tab_ui_strings.grd'))
const androidWebappsStringsPath = path.resolve(path.join(srcDir, 'components', 'webapps', 'browser', 'android', 'android_webapps_strings.grd'))
const braveAndroidWebappsStringsPath = path.resolve(path.join(srcDir, 'brave', 'components', 'webapps', 'browser', 'android', 'android_webapps_strings.grd'))
const androidBrowserUiStringsPath = path.resolve(path.join(srcDir, 'components', 'browser_ui', 'strings', 'android', 'browser_ui_strings.grd'))
const braveAndroidBrowserUiStringsPath = path.resolve(path.join(srcDir, 'brave', 'components', 'browser_ui', 'strings', 'android', 'browser_ui_strings.grd'))


// component_chromium_strings.grd and any of its parts files that we track localization for in transifex
Expand Down Expand Up @@ -140,7 +142,8 @@ function getAutoGeneratedGrdMappings() {
...addGrd(chromiumGeneratedResourcesPath, braveGeneratedResourcesPath, chromiumGeneratedResourcesExcludes),
...addGrd(androidChromeStringsPath, braveAndroidChromeStringsPath),
...addGrd(androidTabUiStringsPath, braveAndroidTabUiStringsPath),
...addGrd(androidWebappsStringsPath, braveAndroidWebappsStringsPath)
...addGrd(androidWebappsStringsPath, braveAndroidWebappsStringsPath),
...addGrd(androidBrowserUiStringsPath, braveAndroidBrowserUiStringsPath)
}
console.log(chalk.italic('Done recursing through GRD to find GRDP files.'))
}
Expand Down
Loading

0 comments on commit ce42903

Please sign in to comment.