Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Chromium icons from save CVC number modal #44092

Open
2 of 6 tasks
srirambv opened this issue Feb 19, 2025 · 2 comments · May be fixed by brave/brave-core#27743
Open
2 of 6 tasks

Remove Chromium icons from save CVC number modal #44092

srirambv opened this issue Feb 19, 2025 · 2 comments · May be fixed by brave/brave-core#27743
Labels
misc/icons OS/Desktop QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Remove Chromium icons from save CVC number modal

Steps to reproduce

  1. Save a card info
  2. Autofill the card info once
  3. Repeat autofill on a different site and enter CVC number
  4. Shows prompt to save CVC number modal but uses Chromium Icons

Actual result

Image

Expected result

Should use Brave icons

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.76.58 Chromium: 133.0.6943.98 (Official Build) beta (64-bit)
Revision e6c9f3240b1045e0f4bcb1301b9a0d7cda5684f8
OS Windows 11 Version 24H2 (Build 26100.2894)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @aguscruiz @fallaciousreasoning
@srirambv srirambv added this to General Feb 19, 2025
@fallaciousreasoning
Copy link

cc @aguscruiz do we care to change this or are the upstream icons fine?

@aguscruiz
Copy link

I would like to change the colors for the top illustration so they use the Brave purple, the rest of the icons can stay the same. But I couldn't find the original illustration in the source code

@aguscruiz aguscruiz linked a pull request Feb 20, 2025 that will close this issue
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
misc/icons OS/Desktop QA/Yes release-notes/include
Projects
General
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add save_cvc image for 1x and 2x brave/brave-core
3 participants
@fallaciousreasoning @aguscruiz @srirambv