[ZCash] Add shardtree + zcash_client_backend crates #26474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-audit-deps
cypt4
force-pushed
the
shard_crate_impl
branch
from
de9f69a to
9192b28
Compare
cypt4
force-pushed
the
shard_crate_impl
branch
from
9192b28 to
a3ccf60
Compare
24 tasks
cypt4
force-pushed
the
shard_crate_impl
branch
from
a3ccf60 to
284506d
Compare
cypt4
changed the title
cypt4
force-pushed
the
shard_crate_impl
branch
from
284506d to
43ffff7
Compare
fmarier
approved these changes
Nov 19, 2024
bridiver
reviewed
Nov 19, 2024
| @@ -0,0 +1,383 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
this is odd, I wonder why this was added if bitflags is already vendored and no version changes. cc @cdesouza-chromium
There was a problem hiding this comment.
This file can be deleted. I've rebased this branch and ran gnrt and it seems to be all good. This PR needs to be rebased anyway, and gnrt has to be rerun, because otherwise we will have a dirty gnrt run tree in master. I would advise to delete this folder, and run gnrt with this PR on master.
bridiver
reviewed
Nov 19, 2024
| @@ -242,3 +242,8 @@ package = "zerocopy" | |||
| [patch.crates-io.zerocopy_derive_v0_7] | |||
| path = "../../../../third_party/rust/chromium_crates_io/vendor/zerocopy-derive-0.7.35" | |||
| package = "zerocopy-derive" | |||
|
|
|||
| [patch.crates-io.zcash_client_backend_v0_12] | |||
| path = "../../../components/brave_wallet/browser/zcash/rust/librustzcash/src/zcash_client_backend" | |||
There was a problem hiding this comment.
just leaving a placeholder for myself that I need to audit this code as well for any potential chromium concerns
There was a problem hiding this comment.
github-actions
bot
added
the
chromium-version-mismatch
|
closed, reopened #26966 |
|
closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#40408
Previous pr : #25092
Audit : https://github.com/brave/reviews/issues/1724
zcash_client_backend audit: https://github.com/brave/reviews/issues/1799
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: