Implements UIs for the "create account" and "sign in" flows in brave://settings
#26741
+1,543
−12
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /* Copyright (c) 2024 The Brave Authors. All rights reserved. | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| * You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { sendWithPromise } from '//resources/js/cr.js' | ||
|
|
||
| export interface BraveAccountBrowserProxy { | ||
szilardszaloki marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| getPasswordStrength(password: string): Promise<number> | ||
| } | ||
|
|
||
| export class BraveAccountBrowserProxyImpl implements BraveAccountBrowserProxy { | ||
| getPasswordStrength (password: string) { | ||
| return sendWithPromise('getPasswordStrength', password) | ||
| } | ||
|
|
||
| static getInstance() { | ||
| return instance || (instance = new BraveAccountBrowserProxyImpl()) | ||
| } | ||
| } | ||
|
|
||
| let instance: BraveAccountBrowserProxy | null = null | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* Copyright (c) 2024 The Brave Authors. All rights reserved. | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| * You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| /* #css_wrapper_metadata_start | ||
| * #type=style-lit | ||
| * #css_wrapper_metadata_end */ | ||
|
|
||
| .label { | ||
| color: var(--leo-color-text-primary); | ||
| font: var(--leo-font-small-semibold); | ||
| margin: 0px 0px 0px var(--leo-spacing-s); | ||
| } | ||
|
|
||
| .label.error { | ||
| color: var(--leo-color-systemfeedback-error-text); | ||
| } | ||
|
|
||
| leo-input { | ||
| --leo-control-border-color: var(--leo-color-divider-strong); | ||
| } | ||
|
|
||
| leo-input:not(:focus):has(> .error) { | ||
| --leo-control-border-color: var(--leo-color-systemfeedback-error-icon); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* Copyright (c) 2024 The Brave Authors. All rights reserved. | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| * You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| export function onEyeIconClicked(event: Event) { | ||
| event.preventDefault() | ||
| let type = 'password' | ||
| const target = event.target as Element | ||
| target.setAttribute('name', | ||
| target.getAttribute('name') === 'eye-off' | ||
| ? (type = 'text', 'eye-on') | ||
| : 'eye-off') | ||
| target.parentElement!.setAttribute('type', type) | ||
| } | ||
|
|
||
| export function isEmailValid(input: string) { | ||
| if (!input) { | ||
szilardszaloki marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // input is falsy | ||
| return false | ||
| } | ||
|
|
||
| if (!/^[\x20-\x7F]+$/.test(input)) { | ||
| // input contains characters outside printable ASCII | ||
| return false | ||
| } | ||
|
|
||
| const index = input.lastIndexOf('@') | ||
| if (index === -1) { | ||
| // there's no @ sign in input | ||
| return false | ||
| } | ||
|
|
||
| if (index === 0 || index === input.length - 1) { | ||
| // there are no characters either before or after the last @ sign | ||
| return false | ||
| } | ||
|
|
||
| return true | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* Copyright (c) 2024 The Brave Authors. All rights reserved. | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| * You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| /* #css_wrapper_metadata_start | ||
| * #type=style-lit | ||
| * #scheme=relative | ||
| * #import=./brave_account_common.css.js | ||
| * #include=brave-account-common | ||
| * #css_wrapper_metadata_end */ | ||
|
|
||
| .dropdown { | ||
| height: var(--height); | ||
| margin: calc(-1 * var(--height)) var(--leo-spacing-s) 0px var(--leo-spacing-s); | ||
| position: relative; | ||
| transition: all 750ms; | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. I'll leave it up to @aguscruiz, but I just checked and even |
||
| z-index: -1; | ||
| } | ||
|
|
||
| .dropdown.visible { | ||
| margin-top: var(--leo-spacing-s); | ||
| } | ||
|
|
||
| #brave-alias-dropdown { | ||
| --height: 36px; | ||
| --leo-icon-size: var(--leo-icon-xs); | ||
| display: flex; | ||
| font: var(--leo-font-small-regular); | ||
| gap: var(--leo-spacing-s); | ||
| } | ||
|
|
||
| #password-dropdown { | ||
| --height: 18px; | ||
| display: flex; | ||
| } | ||
|
|
||
| #password-confirmation-dropdown { | ||
| --height: 18px; | ||
| --leo-icon-size: var(--leo-icon-xs); | ||
| align-items: center; | ||
| display: flex; | ||
| font: var(--leo-font-small-regular); | ||
| gap: var(--leo-spacing-s); | ||
| } | ||
|
|
||
| leo-icon[name=check-circle-filled] { | ||
| --leo-icon-color: var(--leo-color-text-interactive); | ||
| } | ||
|
|
||
| leo-icon[name=check-circle-filled] + div { | ||
| color: var(--leo-color-text-interactive); | ||
| } | ||
|
|
||
| leo-icon[name=warning-triangle-filled] { | ||
| --leo-icon-color: var(--leo-color-systemfeedback-error-icon); | ||
| } | ||
|
|
||
| leo-icon[name=warning-triangle-filled] + div { | ||
| color: var(--leo-color-systemfeedback-error-text); | ||
| } | ||
|
|
||
| leo-checkbox a { | ||
| color: var(--leo-color-text-interactive); | ||
| font: var(--leo-font-default-link); | ||
| text-decoration-skip-ink: none; | ||
| text-underline-offset: 2.8px; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update that since we are shipping accounts without support for Sync (for the time being).