-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add new browser menu UI #26805
Conversation
ec94c65
to
0640546
Compare
Chromium major version is behind target branch (131.0.6778.85 vs 132.0.6834.15). Please rebase. |
0640546
to
d93ad14
Compare
cd0ffe6
to
061e6e7
Compare
061e6e7
to
9368e93
Compare
This adds a new modern browser menu UI behind the feature flag `brave-use-modern-browser-menu`
9368e93
to
4b23f25
Compare
[puLL-Merge] - brave/brave-core@26805 DescriptionThis PR introduces a new modern browser menu UI for the Brave iOS app. The new menu is implemented using SwiftUI and offers customizable actions, VPN status integration, and a more visually appealing design. The feature is behind a feature flag and can be toggled on/off. Possible Issues
Security HotspotsNo significant security issues were identified in this change. ChangesChanges
sequenceDiagram
participant User
participant BrowserViewController
participant BrowserMenuController
participant BrowserMenuModel
participant BrowserMenu
User->>BrowserViewController: Taps menu button
BrowserViewController->>BrowserMenuController: Create and present menu
BrowserMenuController->>BrowserMenuModel: Initialize with actions
BrowserMenuController->>BrowserMenu: Create SwiftUI view
BrowserMenu->>User: Display menu
User->>BrowserMenu: Interact with menu items
BrowserMenu->>BrowserMenuModel: Update action visibility/order
BrowserMenuModel->>BrowserMenu: Reflect changes
User->>BrowserMenu: Dismiss menu
BrowserMenu->>BrowserViewController: Return to main view
|
4b23f25
to
a01109c
Compare
Released in v1.75.97 |
This adds a new modern browser menu UI behind the feature flag
brave-use-modern-browser-menu
Resolves brave/brave-browser#42836
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Screenshots
Menu:
Customize: