Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add local search to Playlist #26933

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Dec 9, 2024

Resolves brave/brave-browser#42437

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Add videos to playlist to multiple folders
  • Open Playlist and tap the search button in the top right
  • Verify you can search for items in multiple folders by name
  • Verify items shown show the correct download states
  • Verify long pressing on items shows the same context menu and that those buttons work correctly
  • Verify that tapping on an item starts playing that item the same way as if tapped on the main sidebar/drawer list

Screenshots

a b c
Simulator Screenshot - iPhone 16 Pro - 2024-12-09 at 12 29 00 Simulator Screenshot - iPhone 16 Pro - 2024-12-09 at 12 29 03 Simulator Screenshot - iPhone 16 Pro - 2024-12-09 at 12 35 55

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Dec 9, 2024
@kylehickinson kylehickinson self-assigned this Dec 9, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner December 9, 2024 17:34
@kylehickinson kylehickinson force-pushed the ios-playlist-local-search branch from d318fae to 51fabb7 Compare December 9, 2024 17:42
Copy link
Contributor

@Brandon-T Brandon-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tested all functionality. Can't seem to break anything. Also tried deleting items during searching and deleting offline data, etc.

It doesn't break anything. So LGTM :)

@kylehickinson kylehickinson merged commit 17a7985 into master Dec 12, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-playlist-local-search branch December 12, 2024 17:20
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 12, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to search local items saved in Playlist
3 participants