Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Disable NotificationAdPopupBrowserTest #26960

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[ads] Disable NotificationAdPopupBrowserTest #26960

merged 1 commit into from
Dec 10, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Dec 10, 2024

Disabled NotificationAdPopupBrowserTest due to:

  • Custom notification ad feature is currently disabled
  • NotificationAdPopupBrowserTest gives different results on different versions of Windows, so it can fail on CI

We will possibly re-enable them in future if we decide to go with custom push notification ads feature.

Resolves brave/brave-browser#42797

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

No manual testing is required.

@aseren aseren added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Dec 10, 2024
@aseren aseren requested review from tmancey and emerick December 10, 2024 19:13
@aseren aseren merged commit fa52e6c into master Dec 10, 2024
21 checks passed
@aseren aseren deleted the issues/42797 branch December 10, 2024 21:46
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 10, 2024
brave-builds added a commit that referenced this pull request Dec 10, 2024
brave-builds added a commit that referenced this pull request Dec 10, 2024
kjozwiak pushed a commit that referenced this pull request Dec 11, 2024
kjozwiak pushed a commit that referenced this pull request Dec 11, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Disable NotificationAdPopupBrowserTest
4 participants