Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toolbar]: Fix console error (uplift to 1.74.x) #26962

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[Toolbar]: Fix console error (uplift to 1.74.x) #26962

merged 1 commit into from
Dec 10, 2024
+1 −1

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 10, 2024 •
edited by LaurenWags
Loading

Uplift of #26673
Resolves brave/brave-browser#42410
Resolves brave/brave-browser#42766

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner December 10, 2024 19:37
@brave-builds brave-builds added this to the 1.74.x - Beta milestone Dec 10, 2024
@brave-builds brave-builds self-assigned this Dec 10, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 10, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

LaurenWags
LaurenWags approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.74.x is approved 👍🏻 QA has verified the PR using 1.75.x/Nightly as per #26673 (comment).

@LaurenWags LaurenWags merged commit c4a2c55 into 1.74.x Dec 10, 2024
17 checks passed
@LaurenWags LaurenWags deleted the pr26673_tb-extra-error_1.74.x branch December 10, 2024 21:32
@brave-builds
Copy link
Collaborator Author

Released in v1.74.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @LaurenWags