Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 131.0.6778.108 to Chromium 131.0.6778.139 (1.73.x) #26973

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Upgrade from Chromium 131.0.6778.108 to Chromium 131.0.6778.139 (1.73.x) #26973

merged 3 commits into from
Dec 11, 2024

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Dec 10, 2024

Resolves brave/brave-browser#42804

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added this to the 1.73.x - Release #5 milestone Dec 10, 2024
@emerick emerick self-assigned this Dec 10, 2024
@emerick emerick requested a review from a team as a code owner December 10, 2024 22:59
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Dec 10, 2024
@cdesouza-chromium @emerick
[cr132] Revert "[cr131] Tab::set_group => Tab::SetGroup"
890d544 
This reverts commit d9a3fa1.

This got reverted in upstream

Chromium change:
https://chromium.googlesource.com/chromium/src/+/1eadd223cce221615fa18db6647451a26a0315a2

commit bf601391652cebeaae149fab39eda062a5f28732
Author: Nasko Oskov <[email protected]>
Date:   Thu Oct 31 16:57:50 2024 +0000

    Revert "[views-ax] Migration of kName attribute in Tab"

    This reverts commit 1eadd223cce221615fa18db6647451a26a0315a2.

    Reason for revert: This CL has regressed window name availability to a11y APIs - https://crbug.com/374947846.

    Original change's description:
    > [views-ax] Migration of kName attribute in Tab
    >
    > This CL migrates the kName attribute in views to be updated
    > whenever its value should change, rather than querying the value
    > and computing it only when needed.
    >
    > As part of this change, the following views are updated:
    > Tab, BrowserView, PermissionChipView, and TabSlotView. The Tab
    > class extends TabSlotView. BrowserView::GetAccessibleTabLabel
    >  constructs the accessible name for a tab by gathering various
    > properties such as the title, group, memory usage, and possibly
    > other elements like permission chips, to create a comprehensive
    > and accurate label.
    >
    > This CL is part of the ViewsAX project:
    > https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413
    >
    > Bug: 325137417
    > Change-Id: Id1ca1da2e970c82575dff12bd48434f716d4548f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836477
    > Reviewed-by: Jacques Newman <[email protected]>
    > Commit-Queue: Gaurav Kumar <[email protected]>
    > Reviewed-by: Elly FJ <[email protected]>
    > Cr-Commit-Position: refs/heads/main@{#1367340}

    Bug: 325137417
kjozwiak
kjozwiak approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.73.x approved 👍

@kjozwiak kjozwiak merged commit 80ef3d3 into 1.73.x Dec 11, 2024
14 of 16 checks passed
@kjozwiak kjozwiak deleted the 131.0.6778.139_1.73.x branch December 11, 2024 02:05
@brave-builds
Copy link
Collaborator

Released in v1.73.101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@emerick emerick

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.73.x - Release #5
Development

Successfully merging this pull request may close these issues.
4 participants
@emerick @brave-builds @kjozwiak @cdesouza-chromium