Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable screen_ai component download/installation (uplift to 1.73.x) #26982

Merged

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 11, 2024

Uplift of #26167
Fixes brave/brave-browser#41629
Fixes brave/brave-browser#41578
Fixes brave/brave-browser#41877

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

* Disable screen_ai component download/installation

* Disable upstream OCR integration

---------

Co-authored-by: Anthony Tseng <[email protected]>
@bsclifton bsclifton added this to the 1.73.x - Release #6 milestone Dec 11, 2024
@bsclifton bsclifton self-assigned this Dec 11, 2024
@bsclifton bsclifton requested a review from a team as a code owner December 11, 2024 16:48
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.73.x is approved 👍🏻 QA has verified the PR using 1.74.x/Beta as per brave/brave-browser#41629 (comment) and brave/brave-browser#41877 (comment).

@LaurenWags LaurenWags merged commit dfeb51f into 1.73.x Dec 11, 2024
17 checks passed
@LaurenWags LaurenWags deleted the emerick-disable-screen-ai-component-download-1.73.x branch December 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants