Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade direct feed redirect requests to HTTPS, respect strict upgrade setting #26989

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#38282

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a test here to make sure redirects keep working.

@DJAndries
Copy link
Collaborator Author

It would be good to have a test here to make sure redirects keep working.

I'm having trouble mocking redirects using the TestURLLoaderFactory

@fmarier
Copy link
Member

fmarier commented Dec 12, 2024

I'm having trouble mocking redirects using the TestURLLoaderFactory

I don't know whether this approach can work in this case too, but there are some redirect browser tests in

* You can obtain one at https://mozilla.org/MPL/2.0/. */

@DJAndries
Copy link
Collaborator Author

I'm having trouble mocking redirects using the TestURLLoaderFactory

I don't know whether this approach can work in this case too, but there are some redirect browser tests in

* You can obtain one at https://mozilla.org/MPL/2.0/. */

I forgot about embedded servers. added a test

@DJAndries DJAndries merged commit bc5b692 into master Dec 13, 2024
18 checks passed
@DJAndries DJAndries deleted the news-direct-feed-https branch December 13, 2024 02:43
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News' "add this RSS feed" functionality doesn't honor the HTTPS upgrade setting
3 participants