Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server use HistoryDeleteDirectiveSpecifics to remove entries from DB #178

Open
AlexeyBarabash opened this issue Oct 16, 2023 · 0 comments
Open

Make server use HistoryDeleteDirectiveSpecifics to remove entries from DB #178

AlexeyBarabash opened this issue Oct 16, 2023 · 0 comments
Assignees
@DJAndries

Comments

@AlexeyBarabash
Copy link
Collaborator

AlexeyBarabash commented Oct 16, 2023 •
edited
Loading

This is a follow-up for #176 .

Client's PR brave/brave-core#20329 sends in HistoryDeleteDirectiveSpecifics in un-encrypted way.

Server should remove entries by HistoryDeleteDirectiveSpecifics::global_id_directive::global_id converted to client_hash_tag or by HistoryDeleteDirectiveSpecifics::time_range_directive.

When this issue will be resolved, syncer::LowPriorityUserTypes override at client must be reverted.
cc @yrliou , @DJAndries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DJAndries @AlexeyBarabash