Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize logs in go-updater #22

Open
jumde opened this issue Feb 27, 2019 · 3 comments
Open

Sanitize logs in go-updater #22

jumde opened this issue Feb 27, 2019 · 3 comments

Comments

@jumde
Copy link
Contributor

jumde commented Feb 27, 2019

Current log format:

time="2019-02-27T05:31:20Z" level=info msg="request complete" X-Forwarded-For="73.121.137.159, 157.52.75.67" X-Forwarded-Host=go-updater.brave.com http_method=POST http_proto=HTTP/1.1 http_scheme=http remote_addr=73.121.137.159 req_id=160e79999b4f/31vUVbNUag-001580 resp_bytes_length=2954 resp_elapsed_ms=0.356856 resp_status=200 uri="http://go-updater.brave.com/extensions" user_agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36"
  • Sanitize logs to remove IP addresses
  • Limit retention period for logs to 3 days.
@jumde
Copy link
Contributor Author

jumde commented Feb 27, 2019

@bbondy @tomlowenthal - let me know if you have any concerns. cc: @hspencer77

@bbondy
Copy link
Member

bbondy commented Feb 27, 2019

sgtm

@tildelowengrimm
Copy link

Perf imo tbh.

@yrliou yrliou mentioned this issue Mar 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tildelowengrimm @bbondy @jumde