Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve OS Specific Components #57

Open
jsecretan opened this issue Jul 2, 2021 · 2 comments
Open

Serve OS Specific Components #57

jsecretan opened this issue Jul 2, 2021 · 2 comments

Comments

@jsecretan
Copy link

A component ID should have the option of being distributed in an OS specific way. This is motivated by a desire to make OS specific NTP-SI packages for each platform, so that the images can be optimized for mobile, or reflect differences in the platforms (e.g. rewards is not available on iOS and any house campaign should reflect that).

@bbondy
Copy link
Member

bbondy commented Jul 2, 2021

Not opposed but just wanted to share a couple of work arounds that we have currently:

  • If it's not a lot of data, just include different files in the component, 1 per platform. Or a JSON file can for example have a per platform key.
  • Can use different component IDs per platform

@jsecretan
Copy link
Author

Thanks @bbondy fair point and I think @petemill has convinced me that different component ids per platform is probably cleaner. We're having a kick off first thing next week and I'll keep this open until then. If we go a different direction I'll close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants