misc fixes to various components #493
Conversation
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-11-29 23:34:12.672987937 +0000
+++ ./tokens/css/variables.css 2023-11-29 23:33:47.012964636 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Mon Nov 27 2023 16:25:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Nov 29 2023 23:33:47 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-11-30 17:02:56.354469145 +0000
+++ ./tokens/css/variables.css 2023-11-30 17:02:30.390363228 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Mon Nov 27 2023 16:25:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Thu Nov 30 2023 17:02:30 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-12-01 04:17:57.035469696 +0000
+++ ./tokens/css/variables.css 2023-12-01 04:17:30.963515024 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Mon Nov 27 2023 16:25:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 01 2023 04:17:30 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
AlanBreck
requested review from
fallaciousreasoning and
petemill
as code owners
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-12-01 05:20:25.895239088 +0000
+++ ./tokens/css/variables.css 2023-12-01 05:19:59.991304548 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Mon Nov 27 2023 16:25:03 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 01 2023 05:19:59 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
This improves scrolling behavior for the dialog by ensuring that only the body area scrolls, and there's proper padding for header and actions if they exist. Additional changes: - Position has been changed to fixed - The component now accepts attributes native to the <dialog> element (such as autofocus)
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-12-05 23:33:38.280051947 +0000
+++ ./tokens/css/variables.css 2023-12-05 23:33:12.623852327 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Dec 05 2023 20:10:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Tue Dec 05 2023 23:33:12 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-12-06 01:33:13.993124955 +0000
+++ ./tokens/css/variables.css 2023-12-06 01:32:47.749172737 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Dec 06 2023 01:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Dec 06 2023 01:32:47 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @fontsource/[email protected] |
This commit contains multiple improvements for both Alert and AlertCenter. Alert: - Ensures text color is uses the appropriate token for the given alert type - Updates icon size and padding - Aligns icon and actions to the top instead of centering vertically (this is for cases where the alert height gets really tall) AlertCenter: - Defaults positioning to fixed, but provides CSS var to override - Allows alert actions to include an icon - Allows consumer to pass reference to custom alert component
- Safari doesn't currently support requestIdleCallback, so this only calls if it exists on window. - Allows optional title attribute on icon for a11y - Adds --leo-icon-height to account for rectangular icons
Previously, the popup would expand to the width of the control and the label, if the label was horizontally aligned. This ensures that the popup width is based on the control, and not the label. Additionally exposes the control width to the consumer via the --leo-menu-control-width variable, and optionally allows the consumer to set the max-width via --leo-menu-popup-max-width.
|
I'm sorry for the churn on this, but I just squashed the fixup commits into their respective parent commits. |
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://493.pr.nala.bravesoftware.com/ Variables Diff--- ./tokens/css/variables.old.css 2023-12-06 01:53:47.599905526 +0000
+++ ./tokens/css/variables.css 2023-12-06 01:53:20.911932589 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Dec 06 2023 01:11:25 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Dec 06 2023 01:53:20 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
@petemill and @fallaciousreasoning, these are miscellaneous fixes that have been piling up as I'm working on the accounts site. I put them all in one commit in this one PR just to get the ball rolling, but what's the best way to split this out? One PR per component?
Update: I've split out the work into distinct commits. I'd recommend that when we merge, we rebase instead of squash.