Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rules for particular repos #315

Closed
bcaller opened this issue Aug 29, 2023 · 4 comments
Closed

Disable rules for particular repos #315

bcaller opened this issue Aug 29, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@bcaller
Copy link
Contributor

bcaller commented Aug 29, 2023

I don't want this to be abused, but for brave.com it would be helpful to ignore certain rules such as templated hrefs.

@bcaller bcaller added the enhancement New feature or request label Aug 29, 2023
@thypon
Copy link
Member

thypon commented Sep 8, 2023

I was reflecting re this issue, and I feel it should not be the repository to control which rule is disabled, but the rule itself.
I think I'll add a metadata.allowlist and a metadata.blocklist containing regexes of repo names we want, or we don't want to apply rules on.

@bcaller
Copy link
Contributor Author

bcaller commented Sep 8, 2023

The incentive for devs to just block random rules is too high haha? Only issue could be disclosure of private repo names in the public security-action repo, but we can choose to ignore this.

@thypon
Copy link
Member

thypon commented Sep 8, 2023

More like I want to address this issue too #47

Basically I need a rule that applies only to brave and brave-intl but none in brave-experiments

@thypon
Copy link
Member

thypon commented Aug 21, 2024

superseded by repo tagging, and rule based disable

@thypon thypon closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants