Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look only at main world usages #384

Open
1 of 2 tasks
thypon opened this issue Oct 3, 2023 · 1 comment
Open
1 of 2 tasks

Look only at main world usages #384

thypon opened this issue Oct 3, 2023 · 1 comment
Assignees
@thypon
Labels
bug Something isn't working

Comments

@thypon
Copy link
Member

thypon commented Oct 3, 2023

Reference: brave/brave-core#20336 (comment)

Proposed Solution

  • Remove the rule
  • Fork and improve the rule

Cc @bridiver
@thypon thypon added the bug Something isn't working label Oct 3, 2023
@bridiver
Copy link

bridiver commented Oct 3, 2023

I guess maybe we're also looking for people who might be adding new isolated worlds or using the wrong isolated world so maybe we should just ignore usages of ISOLATED_WORLD_ID_BRAVE_INTERNAL which are probably correct? Alternatively we can just leave it as-is since this probably doesn't come up that often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thypon thypon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bridiver @thypon @bcaller