Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port brakeman to reviewdog #55

Open
thypon opened this issue Jan 20, 2023 · 8 comments · Fixed by #60 or #214
Open

Port brakeman to reviewdog #55

thypon opened this issue Jan 20, 2023 · 8 comments · Fixed by #60 or #214
Labels
enhancement New feature or request

Comments

@thypon
Copy link
Member

thypon commented Jan 20, 2023

No description provided.

@thypon thypon changed the title Port breakman to reviewdog Port brakeman to reviewdog Jan 23, 2023
@bcaller bcaller mentioned this issue Jan 31, 2023
Merged
@bcaller
Copy link
Contributor

bcaller commented Jun 20, 2023

broken

@bcaller bcaller reopened this Jun 20, 2023
@bcaller
Copy link
Contributor

bcaller commented Jun 20, 2023

brakeman not found due to bundler issue

@thypon thypon mentioned this issue Jun 20, 2023
Merged
@bcaller
Copy link
Contributor

bcaller commented Jun 21, 2023

https://github.com/brave-intl/publishers/actions/runs/5337811744/jobs/9677623734

@bcaller bcaller reopened this Jun 21, 2023
@thypon
Copy link
Member Author

thypon commented Jun 21, 2023

security-action/assets/reviewdog.sh

Line 40 in cc10e0a

# TODO: fix brakeman on full-scan

@bcaller
Copy link
Contributor

bcaller commented Jun 21, 2023

perhaps because publishers has a Gemfile (not containing brakeman) in its root directory and bundler uses the wrong bundle.

@bcaller
Copy link
Contributor

bcaller commented Jun 21, 2023

Ah OK

@bcaller
Copy link
Contributor

bcaller commented Jun 21, 2023

though this is not full scan

@thypon
Copy link
Member Author

thypon commented Jun 21, 2023

I was thinking of disabling that until we have a working PoC since it does not seem to work in any meaningful condition at the current stage.

@thypon thypon mentioned this issue Jun 21, 2023
Merged
@thypon thypon added the enhancement New feature or request label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Brakeman? brave/security-action
reviewdog.yml: unfix brakeman brave/security-action
2 participants
@thypon @bcaller