Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit the changes to build/ and data/ in the npm-publish github action #83

Open
nvonpentz opened this issue Aug 31, 2023 · 0 comments · May be fixed by #85
Open

Commit the changes to build/ and data/ in the npm-publish github action #83

nvonpentz opened this issue Aug 31, 2023 · 0 comments · May be fixed by #85
Assignees

Comments

@nvonpentz
Copy link
Member

It will be better have this data committed and tracked in git so we can easily look up what data is and is not included in the package + history. I also want to commit the changes to data/ because this will allow us to add to the data cache during the build step in addition to manually. I'll need that to cache the is_erc20 values for each token when creating the token lists via Ankr in #82.

@nvonpentz nvonpentz self-assigned this Aug 31, 2023
@nvonpentz nvonpentz linked a pull request Aug 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant