Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix socket support #46

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Unix socket support #46

merged 1 commit into from
Sep 17, 2024

Conversation

ibukanov
Copy link
Collaborator

The new Brave BAT payments service uses viproxy to expose the service in the nitro enclave. For local testing outside AWS we plan to simulate Nitro by using a container that does not have an IP network but rather uses Unix sockets to communicate to the outside world. To cover that add support for directing the traffic into a unix socket.

For symmetry also allow to listen on UNIX sockets.

@ibukanov ibukanov requested a review from thypon September 17, 2024 08:28
The new Brave BAT payments service uses viproxy to expose the service in
the nitro enclave. For local testing outside AWS we plan to simulate
Nitro by using a container that does not have an IP network but rather
uses Unix sockets to communicate to the outside world. To cover that add
support for directing the traffic into a unix socket.

For symmetry also allow to listen on UNIX sockets.

Report an explicit error when net.Addr is unsupported.
@ibukanov ibukanov force-pushed the igor/support-unix-socket branch from 984acfa to cdb323b Compare September 17, 2024 08:35
Copy link
Member

@thypon thypon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we enable this only when a specific flag is passed?

@ibukanov
Copy link
Collaborator Author

The PR does not affect the usage of the proxy in the existing command-line tools as the code has to explicitly construct net.UnixAddr.

@ibukanov ibukanov merged commit b3e0296 into master Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants