Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeable Instances Seem Necessary in ghc9.8.2 #1016

Closed
Montmorency opened this issue Jan 13, 2025 · 4 comments
Closed

Typeable Instances Seem Necessary in ghc9.8.2 #1016

Montmorency opened this issue Jan 13, 2025 · 4 comments

Comments

@Montmorency
Copy link

I'm trying to compile amazonka with ghc9.8.2 and haskell-updates version of nixpkgs and I was required to add 'Typeable a' and Typeable (AWSResponse a) constraints to a number of function in order to compile. PR.

@endgame
Copy link
Collaborator

endgame commented Jan 13, 2025

I need to know what revisions of Amazonka and nixpkgs you are using. A full Nix expression showing the build you are trying to perform would be best.

Note that nixpkgs builds its Haskell package set from Hackage release, starting with a Stackage snapshot. This means that at best you'll have Amazonka 2.0 which does not support GHC 9.8 at all (due to a change in the way DuplicateRecordFields is handled).

Git main has been fixed, so you'll need a Nix expression that gets amazonka-core, amazonka, and any service bindings you need from the git repo.

@Montmorency
Copy link
Author

Montmorency commented Jan 13, 2025

Hey thanks! amazonka rev = "fbc91ee7d0434b7614e3fe8de993348a4c6ca7a3"; and nixpkgs="github:NixOS/nixpkgs?rev=54b4bb956f9891b872904abdb632cea85a033ff2" ghc-9.8.2

I was actually overriding the hackage version in my nix build (because of the issue you mentioned with DuplicateRecordFields could not build with GHC 9.8) in -sts and -sso which is how I came across these errors in the first place. When I built from main and added these instances I could get everything to compile (had to also override micro-lens pro as its marked broken in nixpkgs) .

Re: the hackage version. What is the process for uploading a new Version 2.1 to Hackage? This would be cut from latest master with the DuplicateRecordFields fix (and others e.g. microlens dependencies etc.)? Then amazonka would work directly with the default nixpkgs/haskell-updates default package set on the latest ghc.

@Montmorency
Copy link
Author

Looks like #1015 works. Thanks!

@endgame
Copy link
Collaborator

endgame commented Jan 14, 2025

What is the process for uploading a new Version 2.1 to Hackage?

Completing the 2.1 Milestone, publishing an RC for people to point at from git, then working through the release checklist and asking Brendan to send it all to Hackage when that's done.

had to also override micro-lens pro as its marked broken in nixpkgs

If all it needed was an unmarkBroken and it built on haskellPackages.ghc (as in, the default without asking for a specific version) then I'd recommend PRing nixpkgs' haskell-updates branch with something like NixOS/nixpkgs#283858 so they can re-add it to the standard package set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants