[ELIX-41] Add details field to gRPC error struct #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishab-brex
changed the title
Adds a details field of type [any()] to the error struct and updates the transport layer to properly encode + decode them.
rishab-brex
force-pushed
the
rishab/rich-errors
branch
from
57932f2 to
f4fd1e5
Compare
rishab-brex
commented
Oct 19, 2021
| %{ | ||
| "grpc-status" => Integer.to_string(status), | ||
| "grpc-message" => message | ||
| "grpc-message" => message, | ||
| "grpc-details" => details |> Enum.join(",") |
There was a problem hiding this comment.
we need to be able to encode the details field (a list of of type [any()]) to a string and back without knowing the types. is there a way to do this without knowing the type of struct/string/integer/etc. to decode to?
rishab-brex
commented
Oct 19, 2021
| assert %GRPC.RPCError{ | ||
| status: GRPC.Status.unauthenticated(), | ||
| message: "string_errors", | ||
| details: ["hello", "world"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a details field of type [any()] to the error struct and updates the
transport layer to properly encode + decode them.
Jira ticket: https://brexhq.atlassian.net/browse/ELIX-41
Motivation: https://docs.google.com/document/d/1XgMF_YjbHQn8I4Aib9qOO69A0Y6k3CjLpswjLvErvh0/edit