Update decoder.ex #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziepaquette
requested changes
May 27, 2020
There was a problem hiding this comment.
What happens when you set wire type as an atom? (I saw tony setting wire type explicitly in tests) https://github.com/brexhq/protobuf-elixir/blob/master/lib/protobuf/encoder.ex#L248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i want to do some crazy stuff with bazel; bazel likes to output various metadata in files which consist of length-delimited serialized protobufs. They say you can use parseDelimitedFrom in the java protobuf library https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Parser.html#parseDelimitedFrom-java.io.InputStream- so this is basically that for elixir . Not sure if this is what :bytes_len is supposed to do but I couldn't make it work so I added a new case......