Update Makie to 0.21 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Invalid attribute norays for plot type MakieCore.Mesh. Not used by draw!, and not found anywhere else in OpticSim.
brianguenter
approved these changes
Aug 20, 2024
|
Good idea, splitting the long keyword arguments onto separate lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Makie to 0.21 (latest), in the hope that it fixes the doc CI (#35 (comment)).
The
no method matching leafandGridRectOriginPointserrors described in #35 (comment)) are still there,but aren't related to Makie.
It looks like
debugandnorayswere silently ignored by previous Makie versions, which was unnoticeduntil Makie 0.21 where wrong attributes errors (good).
As a proposal, the long signatures have been split with one line per kwarg.
That feels more readable to me, and allows to comment close to specific kwargs.
Please let me know if this is OK or not, and I'll update this PR.