Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport as from tko.binding.foreach #47

Open
brianmhunt opened this issue Jan 6, 2017 · 5 comments
Open

Backport as from tko.binding.foreach #47

brianmhunt opened this issue Jan 6, 2017 · 5 comments

Comments

@brianmhunt
Copy link
Owner

This: knockout/tko.binding.foreach@b3380c9

@cervengoc – If you get a chance, please feel free to incorporate the changes from the referenced patch.

Cheers.

@jensb
Copy link

jensb commented Oct 30, 2019

Yes, can we please do this? We are using the 'as' parameter heavily in knockout-v3.5 (see also issue 52) and would love to benefit from the speedup this library provides.

@brianmhunt
Copy link
Owner Author

Thanks @jensb — do you think you'd be able to put together a PR?

@jensb
Copy link

jensb commented Nov 1, 2019

I tried. Let's see if it works, shall we? :-)

@jensb
Copy link

jensb commented Nov 6, 2019

Can you please tes this PR? I am getting errors about $parent being undefined when testing it on my app. Is this variable now obsolete (and what do I replace it with)?

@brianmhunt
Copy link
Owner Author

Hi @jensb I'm not set up to test this right now, but if $parent is missing, I'd think the problem is with one of the return values of createContextGenerator — in particular look to see if what they return contains $parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants