You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @BenMorel,
thanks a lot for your work and this library.
During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:
[...]
public const DATE_IMMUTABLE = 'date_immutable';
public const DATEINTERVAL = 'dateinterval';
public const DATETIME_MUTABLE = 'datetime';
public const DATETIME_IMMUTABLE = 'datetime_immutable';
public const DATETIMETZ_MUTABLE = 'datetimetz';
public const DATETIMETZ_IMMUTABLE = 'datetimetz_immutable';
[...]
while in your library you use the camelCase notation:
[...]
final class LocalDateTimeType extends Type
{
public function getName(): string
{
return 'LocalDateTime';
}
[...]
Can I ask you why? Would you consider to change this if I open a pull request for this change?
Hope to hear from you soon
The text was updated successfully, but these errors were encountered:
Hi, no particular reason, but personal preference. I don't think it hurts much, we use it this way in our codebase at work, but let's see what others think about it?
Hi @BenMorel,
thanks a lot for your work and this library.
During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:
while in your library you use the camelCase notation:
Can I ask you why? Would you consider to change this if I open a pull request for this change?
Hope to hear from you soon
The text was updated successfully, but these errors were encountered: