Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Doctrine types name format #3

Open
paoloconi96 opened this issue Jun 16, 2022 · 2 comments
Open

Different Doctrine types name format #3

paoloconi96 opened this issue Jun 16, 2022 · 2 comments

Comments

@paoloconi96
Copy link

Hi @BenMorel,
thanks a lot for your work and this library.

During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:

[...]
    public const DATE_IMMUTABLE       = 'date_immutable';
    public const DATEINTERVAL         = 'dateinterval';
    public const DATETIME_MUTABLE     = 'datetime';
    public const DATETIME_IMMUTABLE   = 'datetime_immutable';
    public const DATETIMETZ_MUTABLE   = 'datetimetz';
    public const DATETIMETZ_IMMUTABLE = 'datetimetz_immutable';
[...]

while in your library you use the camelCase notation:

[...]
final class LocalDateTimeType extends Type
{
    public function getName(): string
    {
        return 'LocalDateTime';
    }
[...]

Can I ask you why? Would you consider to change this if I open a pull request for this change?

Hope to hear from you soon

@BenMorel
Copy link
Member

Hi, no particular reason, but personal preference. I don't think it hurts much, we use it this way in our codebase at work, but let's see what others think about it?

@paoloconi96
Copy link
Author

Hi! Yes, I don't see any problem with this either. I was asking just for a uniformity purpose.
Let's see what everybody else thinks. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants