Fixes #23 KeyError: ['beta', 'SE'] when using Z #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #23 KeyError: ['beta', 'SE'] when using Z.
It also adds a few print statements to inform the user when popcorn uses CHR:POS as SNP identifier, or when popcorn re-calculates Z column from beta and SE. Both steps are convenient to have, but in some cases they might be problematic, and thus it's good to bring them to user's attention. The problem with CHR:POS as identifier is that two different variants could have the same location, so CHR:POS is somewhat ambiguous as an identifier. The problem with re-calculating Z is that this behaviour is somewhat not intuitive - I would expect that if Z score is provided in the input popcorn will take it as use as it is, even if
betaandSEcolumns are also specified. I would suggest to add a line in the readme to clarify that ifbetaandSEare provided, then popcorn will use those and ignoreZcolumn if it's part of the input summary statistics.