Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video title and description does not update #59

Open
cmstroscio opened this issue Oct 24, 2019 · 2 comments
Open

video title and description does not update #59

cmstroscio opened this issue Oct 24, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@cmstroscio
Copy link

Screen Shot 2019-10-24 at 12 17 49 PM

Hello,
First of all, this is a great tool. Thank you!

I have an app that filters a set of tiles / cards with videos in them (see screenshot). I'm having an issue where the user plays a video, then selects a new filter. The cards / tiles and video update as expected. However, the video title and description persist from the previously played video. In other words, the title and description do not update with the video.

I've installed the react-player-loader via npm and imported it into my app:
import ReactPlayerLoader from '@brightcove/react-player-loader';

Then I have an onSuccess function:

  let reactPlayerLoader;
  const onSuccess = function(success) {

    // The player object or iframe element (depending on embed type) can be
    // accessed in two ways.
    // 
    // From the success object passed to the `onSuccess` callback:
    console.log("success description", success.ref );

    // As a property of the component instance:

  };

And this is how I'm using the player loader component:
<ReactPlayerLoader videoId={videoLink.videoId} accountId={videoLink.accountId} playerId={videoLink.playerId} onSuccess={onSuccess}/>

I hope that makes sense. Please let me know if you need any more information. Any assistance you can provide would be great.

Thanks
Marshall

@misteroneill
Copy link
Member

We're glad you're finding the tool useful, Marshall! That's an interesting issue, thanks for the report. I'm not sure what is going on.

Hopefully we can take a look at some point.

@misteroneill misteroneill added the bug Something isn't working label Oct 25, 2019
@cmstroscio
Copy link
Author

cmstroscio commented Oct 25, 2019

Cool, please let me know if you figure anything out!

If you're interested or it helps debug, we went live with this project today:

https://www.netapp.com/us/data-visionary/index.aspx (scroll down to Data Visionary Stories)

For now, we've hidden the title and description with CSS on the big tiles at the top.

.n-content-hub__top-section--no-hover .vjs-dock-description, .n-content-hub__top-section--no-hover .vjs-dock-title { display: none; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants