Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose spotifyUri on iOS #94

Merged
merged 8 commits into from
Apr 10, 2021
Merged

Expose spotifyUri on iOS #94

merged 8 commits into from
Apr 10, 2021

Conversation

fotiDim
Copy link
Collaborator

@fotiDim fotiDim commented Apr 9, 2021

#93 needs to be merged fist.

This PR closes #86.
It also fixes a bug where appRemote was not initialized properly when connecting with an existing accessToken.

@fotiDim fotiDim requested a review from brim-borium April 9, 2021 18:18
Copy link
Owner

@brim-borium brim-borium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some questions. Need to test this on Android/check wether we can use something here as well

lib/spotify_sdk.dart Outdated Show resolved Hide resolved
lib/spotify_sdk.dart Outdated Show resolved Hide resolved
lib/spotify_sdk.dart Outdated Show resolved Hide resolved
lib/spotify_sdk.dart Outdated Show resolved Hide resolved
lib/spotify_sdk.dart Show resolved Hide resolved
@fotiDim fotiDim force-pushed the feature/expose-spotifyUri-iOS branch from 4b3dcd4 to 68ebcdd Compare April 10, 2021 08:39
@brim-borium
Copy link
Owner

Got some questions. Need to test this on Android/check wether we can use something here as well

Android doesn't use any of the introduced features so this can be merged

@fotiDim fotiDim merged commit 03b1348 into main Apr 10, 2021
@fotiDim fotiDim deleted the feature/expose-spotifyUri-iOS branch August 22, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currently-selected song begins playing when connecting to Spotify on iOS
2 participants